Skip to content

feat: re-emit REST debug logs #10782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

feat: re-emit REST debug logs #10782

merged 1 commit into from
Feb 25, 2025

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Feb 24, 2025

Re-emit /rest debug event on discord.js' debug event, just like the debug event from /ws

To provide better context, added a seemingly missing prefix from REST's class debug logs, which is already present on the individual handlers, like

this.manager.emit(RESTEvents.Debug, `[REST ${this.id}] ${message}`);

Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Feb 24, 2025 9:35pm
discord-js-guide ⬜️ Ignored (Inspect) Feb 24, 2025 9:35pm

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.66%. Comparing base (a1d19b9) to head (0cfffb0).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/rest/src/lib/REST.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10782   +/-   ##
=======================================
  Coverage   38.65%   38.66%           
=======================================
  Files         238      238           
  Lines       14646    14644    -2     
  Branches     1385     1385           
=======================================
  Hits         5662     5662           
+ Misses       8972     8970    -2     
  Partials       12       12           
Flag Coverage Δ
proxy 64.63% <ø> (ø)
rest 87.33% <0.00%> (ø)
ws 34.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit bb67671 into main Feb 25, 2025
25 checks passed
@kodiakhq kodiakhq bot deleted the feat/re-emit-rest-debug-logs branch February 25, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants